pavan51 commented on PR #23827:
URL: https://github.com/apache/datafusion/pull/23827#issuecomment-5067789139
@neilconway Thanks for the detailed review and excellent feedback. I've
addressed all the comments.
The sliding_min_max.rs benchmark now only tests the production MovingMax
implementation directly. To establish the performance delta, I ran the
benchmark against both the main branch (old two-stack implementation) and this
new branch (monotonic deque sequence number).
Here are the results:
## Key Metrics (Old vs New)
### 1. 64-bit Integers (`Int64`)
* **Window Size 1000**
* **Throughput (New)**: ~50 Million elements / sec
* **Throughput (Old)**: ~28 Million elements / sec
* **Delta**: Old code is **~48% slower** (New code is nearly **2x faster**)
* **Time**: Old code takes **+91%** longer to process the same batch.
### 2. Timestamps (`TimestampNanosecond`)
* **Window Size 1000**
* **Throughput (New)**: ~52 Million elements / sec
* **Throughput (Old)**: ~26 Million elements / sec
* **Delta**: Old code is **~50% slower** (New code is exactly **2x
faster**)
* **Time**: Old code takes **+100%** longer to process the same batch.
### 3. Decimals (`Decimal128`)
* **Window Size 1000**
* **Throughput (New)**: ~50 Million elements / sec
* **Throughput (Old)**: ~25 Million elements / sec
* **Delta**: Old code is **~50% slower** (New code is exactly **2x
faster**)
* **Time**: Old code takes **+100%** longer to process the same batch.
### 4. Strings (`Utf8`)
* **Window Size 1000**
* **Throughput (New)**: ~16 Million elements / sec
* **Throughput (Old)**: ~4.6 Million elements / sec
* **Delta**: Old code is **~71% slower** (New code is **3.5x faster**)
* **Time**: Old code takes **+245%** longer to process the same batch.
### Thanks again for the review! Please let me know if anything else is
needed.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
