HairstonE commented on PR #23871: URL: https://github.com/apache/datafusion/pull/23871#issuecomment-5073255299
Hi Neil! > I'm curious -- why do we want to follow the DuckDB behavior here? Integer literal GROUP BY expressions are interpreted as column ordinals, so to me it seems more consistent to reject non-integer literal GROUP BY expressions, as Postgres does. DuckDB has the correct output so I used it for reference. I believe Postgres only blocks bare literals. When it accepts this type of query Postgres has the same behavior as DuckDB. This bug would still persist in constant expression group bys even if we reject the same way Postgres does. Adding this rejection now could also cause query breaking changes. @alamb Do you have any thoughts on this? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
