alamb commented on code in PR #23744:
URL: https://github.com/apache/datafusion/pull/23744#discussion_r3647576723
##########
datafusion/physical-plan/src/execution_plan.rs:
##########
@@ -202,6 +202,22 @@ pub trait ExecutionPlan: Any + Debug + DisplayAs + Send +
Sync {
vec![None; self.children().len()]
}
+ /// Specifies whether the identity or number of rows produced by this plan
+ /// depends on the order of each child input.
+ ///
+ /// Unlike [`Self::required_input_ordering`], this property does not
require
+ /// a particular ordering that can be expressed using the child's schema.
+ /// It only requires that an existing input ordering is not discarded or
+ /// replaced with an incompatible ordering by physical optimizations. For
Review Comment:
This property seems like it is some internal invariant of
EnforceDistribution rather than something that describes how the ExecutionPlan
behaves
I don't think we should add this to the ExecutionPlan trait
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
