alamb commented on code in PR #11924:
URL: https://github.com/apache/datafusion/pull/11924#discussion_r1713543104
##########
datafusion/functions/src/string/ends_with.rs:
##########
@@ -43,14 +41,15 @@ impl Default for EndsWithFunc {
impl EndsWithFunc {
pub fn new() -> Self {
- use DataType::*;
Self {
signature: Signature::one_of(
vec![
- Exact(vec![Utf8, Utf8]),
- Exact(vec![Utf8, LargeUtf8]),
- Exact(vec![LargeUtf8, Utf8]),
- Exact(vec![LargeUtf8, LargeUtf8]),
+ // Planner attempts coercion to the target type starting
with the most preferred candidate.
Review Comment:
❤️ for the comments
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
