andygrove commented on code in PR #1921:
URL:
https://github.com/apache/datafusion-ballista/pull/1921#discussion_r3648709854
##########
ballista/scheduler/tests/tpch_plan_stability/approved/q17.txt:
##########
@@ -16,7 +16,7 @@ SortShuffleWriterExec: partitioning=Hash([l_partkey@0], 16)
ShuffleWriterExec: partitioning: None
AggregateExec: mode=Partial, gby=[], aggr=[sum(lineitem.l_extendedprice)]
ProjectionExec: expr=[l_extendedprice@1 as l_extendedprice]
- SortMergeJoinExec: join_type=Inner, on=[(p_partkey@2, l_partkey@1)],
filter=CAST(l_quantity@0 AS Decimal128(30, 15)) < Float64(0.2) *
avg(lineitem.l_quantity)@1
+ SortMergeJoinExec: join_type=LeftSemi, on=[(p_partkey@2, l_partkey@1)],
filter=CAST(l_quantity@0 AS Decimal128(30, 15)) < Float64(0.2) *
avg(lineitem.l_quantity)@1
Review Comment:
Need to check if this change in join type is valid. Affects other queries
too.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
