andygrove opened a new pull request, #1645:
URL: https://github.com/apache/datafusion-python/pull/1645
# Which issue does this PR close?
Closes #1644.
# Rationale for this change
The workspace dependencies were declared as `version = "54"`, so Cargo was
free
to resolve them to DataFusion 54.1.0 — but the crate no longer compiled when
it
did. DataFusion 54.1.0 added a `schema: DFSchemaRef` field to
`datafusion_expr::logical_plan::RecursiveQuery`, and
`PyRecursiveQuery::new()`
built that struct with a literal initializer:
```
error[E0063]: missing field `schema` in initializer of
`datafusion::logical_expr::RecursiveQuery`
--> crates/core/src/expr/recursive_query.rs:72:20
```
# What changes are included in this PR?
- Bump the workspace DataFusion requirements from `"54"` to `"54.1"` and
update
`Cargo.lock` to 54.1.0. Pinning the minor version keeps the build from
silently
resolving back to 54.0.0, which no longer satisfies the code below.
- Build `RecursiveQuery` through the new `RecursiveQuery::try_new()`
constructor
instead of a struct literal. `try_new()` computes the output schema by
reconciling the static and recursive terms, so it is fallible;
`PyRecursiveQuery::new()` now returns `PyDataFusionResult<Self>`.
- Extend `test_recursive_query` to round-trip the node back through the
Python
constructor, covering the new schema-reconciliation path.
# Are there any user-facing changes?
`datafusion.expr.RecursiveQuery(...)` can now raise when the static and
recursive terms do not have the same number of columns. Previously such
arguments produced a `RecursiveQuery` node that was invalid downstream, so
this
turns a late failure into an immediate one. No other public API changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
