github-actions[bot] commented on PR #23906: URL: https://github.com/apache/datafusion/pull/23906#issuecomment-5083654840
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-ffi v54.1.0 (current) Built [ 66.624s] (current) Parsing datafusion-ffi v54.1.0 (current) Parsed [ 0.064s] (current) Building datafusion-ffi v54.1.0 (baseline) Built [ 61.644s] (baseline) Parsing datafusion-ffi v54.1.0 (baseline) Parsed [ 0.063s] (baseline) Checking datafusion-ffi v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.231s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/constructible_struct_adds_field.ron Failed in: field ForeignLibraryModule.create_table_with_dml in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:115 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_TableProvider.statistics moved from position 6 to 9, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/table_provider.rs:160 FFI_TableProvider.logical_codec moved from position 7 to 10, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/table_provider.rs:162 FFI_TableProvider.version moved from position 10 to 13, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/table_provider.rs:172 FFI_TableProvider.library_marker_id moved from position 12 to 15, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/table_provider.rs:181 ForeignLibraryModule.create_physical_optimizer_rule moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:118 ForeignLibraryModule.create_context_aware_optimizer_rule moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:120 ForeignLibraryModule.version moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:122 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 130.200s] datafusion-ffi ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
