timsaucer commented on code in PR #22797:
URL: https://github.com/apache/datafusion/pull/22797#discussion_r3652713258
##########
datafusion/ffi/src/tests/udf_udaf_udwf.rs:
##########
@@ -162,6 +163,55 @@ pub(crate) extern "C" fn create_placement_func() ->
FFI_ScalarUDF {
udf.into()
}
+#[derive(Debug, PartialEq, Eq, Hash)]
+struct WithConfigUpdateUDF {
+ signature: Signature,
+ name: String,
+}
Review Comment:
Would it have been simpler to just implement the method on one of the
existing UDFs?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]