Amogh-2404 commented on code in PR #23069:
URL: https://github.com/apache/datafusion/pull/23069#discussion_r3652936155
##########
datafusion/ffi/src/tests/udf_udaf_udwf.rs:
##########
@@ -162,6 +163,50 @@ pub(crate) extern "C" fn create_placement_func() ->
FFI_ScalarUDF {
udf.into()
}
+#[derive(Debug, PartialEq, Eq, Hash)]
+struct LexOrderingUDF {
+ signature: Signature,
+}
Review Comment:
Fixed. Both paths now use the existing placement UDF, and the dedicated
fixture is gone.
##########
datafusion/ffi/src/udf/mod.rs:
##########
@@ -502,6 +536,33 @@ mod tests {
}
}
+ #[derive(Debug, PartialEq, Eq, Hash)]
+ struct LexOrderingUDF {
+ signature: Signature,
+ }
Review Comment:
Fixed. The unit test now uses the existing placement UDF.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
