Jefffrey commented on code in PR #23916:
URL: https://github.com/apache/datafusion/pull/23916#discussion_r3654678286
##########
datafusion/expr/src/type_coercion/functions.rs:
##########
@@ -1198,13 +1198,11 @@ fn coerced_from<'a>(
) => Some(type_into.clone()),
(
Timestamp(TimeUnit::Nanosecond, None),
- Null | Timestamp(_, None) | Date32 | Utf8 | LargeUtf8,
+ Null | Timestamp(_, None) | Date32 | Date64 | Utf8 | LargeUtf8 |
Utf8View,
Review Comment:
added date64 for the sake of it, since we already have date32 here
##########
datafusion/sqllogictest/test_files/datetime/timestamps.slt:
##########
@@ -1264,6 +1264,12 @@ SELECT DATE_BIN('5 month', '2022-01-01T00:00:00Z');
----
2021-09-01T00:00:00
+# test with utf8view
+query P
+SELECT DATE_BIN(arrow_cast('5 month', 'Utf8View'), '2022-01-01T00:00:00Z');
Review Comment:
this was failing on main before, just an example of what this fix can affect
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
