kosiew commented on code in PR #23670:
URL: https://github.com/apache/datafusion/pull/23670#discussion_r3654910218
##########
datafusion/datasource/src/file_scan_config/mod.rs:
##########
@@ -2480,6 +2483,46 @@ mod tests {
assert_eq!(partition_stats.total_byte_size, Precision::Exact(800));
}
+ #[test]
+ fn test_partition_statistics_filter() {
Review Comment:
Could we rename this test to `test_statistics_with_filter` and update the
helper comment as well? The current name mentions `partition_statistics`, but
the test calls `FileScanConfig::statistics()` directly. Since the
`partition_statistics(Some(_))` path has separate behaviour, the suggested name
would make it clearer which statistics path this test covers.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
