maxburke commented on PR #23032: URL: https://github.com/apache/datafusion/pull/23032#issuecomment-5094003446
> I don't believe this is acceptable until a deeper performance analysis is performed. As it currently stands, it raises a legitimate performance concern, but I am not convinced that the solution is not over-specialized to your use case. DataFusion needs to remain generally performant, and there are too many open questions in my previous comment that have not been explored. @mbutrovich Because I'm just a community member, maybe you could provide some more guidance on specifically what you are looking for in order to get this across the finish line? What would a more acceptable solution look like? As an end user I don't know what others are using; when you say "I am not convinced that the solution is not over-specialized to your use case" I am confused because I don't have any other frame of reference. From my point of view, my queries are no longer crashing, runtime memory is significantly reduced, and all the tests are passing. I don't know what "a deeper performance analysis" entails. You mention "it raises a legitimate performance concern", but what specifically is the metric being measured that is a concern? I look at the benchmarks above and I see some faster and some slower (which makes sense), I don't know which are unacceptably slower. I don't know what tradeoffs are acceptable. I don't know which benchmarks are more important than the others. Are all performance impacting changes unacceptable? (maybe cc @alamb for help) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
