villebro commented on code in PR #2179:
URL:
https://github.com/apache/datafusion-ballista/pull/2179#discussion_r3660457346
##########
ballista-cli/Cargo.toml:
##########
@@ -81,25 +81,57 @@ tokio = { workspace = true, features = ["macros", "sync",
"time"] }
default = ["cli", "tui"]
cli = [
- "dep:ballista", "dep:datafusion", "dep:datafusion-cli",
- "dep:rustyline", "dep:mimalloc",
+ "dep:ballista",
+ "dep:datafusion",
+ "dep:datafusion-cli",
+ "dep:rustyline",
+ "dep:mimalloc",
Review Comment:
Applied, thanks. I did notice a few other ones, too, but applying Taplo's
`reorder_arrays` made very extensive changes. So I would almost defer automated
array reordering to a potential follow-up PR that makes sure we're not
reordering arrays that were intentionally non-ABC ordered.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
