alamb commented on code in PR #23716:
URL: https://github.com/apache/datafusion/pull/23716#discussion_r3663357368
##########
datafusion/functions-aggregate/src/array_agg.rs:
##########
@@ -817,29 +817,40 @@ impl GroupsAccumulator for ArrayAggGroupsAccumulator {
}
}
+/// Resources that are allocated lazily on the first `update_batch` call,
+/// once the concrete runtime Arrow type is known.
+///
Review Comment:
What would be amazing is if we could reuse some of the actual hash aggregate
implementations -- but I don't really know how to do that yet
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
