andygrove commented on code in PR #804:
URL: https://github.com/apache/datafusion-comet/pull/804#discussion_r1714203620
##########
native/core/src/execution/operators/scan.rs:
##########
@@ -109,11 +120,15 @@ impl ScanExec {
/// This is necessary since DataFusion doesn't handle dictionary array
with values
/// being primitive type.
///
- /// TODO: revisit this once DF has imprved its dictionary type support.
Ideally we shouldn't
+ /// TODO: revisit this once DF has improved its dictionary type support.
Ideally we shouldn't
/// do this in Comet but rather let DF to handle it for us.
fn unpack_dictionary_type(dt: &DataType) -> DataType {
if let DataType::Dictionary(_, vt) = dt {
- if !matches!(vt.as_ref(), DataType::Utf8 | DataType::Binary) {
+ if !matches!(
+ vt.as_ref(),
+ DataType::Utf8 | DataType::LargeUtf8 | DataType::Binary
Review Comment:
Added. Thanks.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
