comphead commented on issue #23929: URL: https://github.com/apache/datafusion/issues/23929#issuecomment-5105809266
> is this meant for datafusion-spark only, or for all datafusion functions? This is a really good question. The epic itself is supposed to be an umbrella for ANSI changes, which we already have some and some planning for Spark functions. DataFusion Spark functions mostly are the mostly consumers for the ANSI mode, however the scope could be beyond them. For example window RANGE frame is supposed to behave differently on overflows depending on ANSI flag, the similar would be true for safe casting, math operations, etc. The bottom line is there is no need to make DataFusion ANSI compliant unless there is a good reason for it, however to support Spark projects built on DF like Comet/Auron/Sail we would need to support ANSI in spark functions as well as introducing cosmetical injections in DF core to support ANSI for windows, and other ops. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
