andygrove opened a new issue, #5088: URL: https://github.com/apache/datafusion-comet/issues/5088
### What is the problem the feature request solves? `native/spark-expr/src/timezone.rs` is a full copy of arrow-array's `Tz`/`TzOffset` (the file header says "This is basically from arrow-array::timezone (private)"). In arrow 58, `arrow::array::timezone::Tz` is public when the `chrono-tz` feature is enabled, which our workspace already does. In fact `native/spark-expr/src/kernels/temporal.rs` already imports arrow's `Tz`, so the crate currently carries two parallel, incompatible `Tz` types. ### Describe the potential solution Delete `timezone.rs` and switch its consumers (`spark-expr/src/utils.rs`, `spark-expr/src/conversion_funcs/temporal.rs`, `spark-expr/src/conversion_funcs/string.rs`) to `arrow::array::timezone::Tz`. Consumers only use `FromStr` plus the `chrono::TimeZone` trait, which arrow's type provides identically. ### Additional context Fixed-offset parsing grammars match for Spark-legal offsets: Comet parses via chrono `%:z`/`%#z`, arrow 58 accepts `[+-]XX:XX`, `[+-]XXXX`, `[+-]XX`. Error message text differs slightly but only surfaces as internal errors. Found during an audit of native code that replicates existing arrow-rs kernels. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
