itsjunetime opened a new pull request, #11958: URL: https://github.com/apache/datafusion/pull/11958
## Which issue does this PR close? Closes #11957 ## Rationale for this change It's nice to keep ahead of future rust changes and make sure people can comfortably use this library on any toolchain. ## What changes are included in this PR? - Fixed all issues reported by clippy (but 1, mentioned in the attached issue) - Refactored the `make_error` macro that's used to make all the errors + variants to prevent code duplication and get rid of unnecessary `with_dollar_sign` macro ## Are these changes tested? Yes, it passes all tests that main currently passes on my machine. ## Are there any user-facing changes? This adds items to the public API, under `#[doc(hidden)]`. This is not a breaking change afaik, but would cause a breaking change if they were removed. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
