parthchandra commented on code in PR #4952:
URL: https://github.com/apache/datafusion-comet/pull/4952#discussion_r3669940733
##########
native/core/src/execution/planner.rs:
##########
@@ -1601,6 +1610,26 @@ impl PhysicalPlanner {
)),
))
}
+ OpStruct::ContribScan(contrib) => {
+ // Extension point for optional, out-of-tree contrib scans
(Delta, Lance, ...). The
+ // concrete scan message is packed into the `ContribScan`
envelope on the JVM side;
+ // here we route by `type_url` to whichever contrib was
compiled in. Core names no
+ // specific contrib: the type_url match + decode lives
entirely inside each
+ // contrib's gated module, so a default build carries zero
contrib surface. The arm
+ // itself is unconditional so a default build that receives a
contrib-shaped plan
+ // from a misconfigured driver gets a clear error instead of a
"no match" decode
+ // failure.
+ #[cfg(feature = "contrib-delta")]
Review Comment:
Rust dynamic loading ref: https://nullderef.com/blog/plugin-dynload/
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
