KarpagamKarthikeyan commented on PR #23962: URL: https://github.com/apache/datafusion/pull/23962#issuecomment-5114000041
cc @Jefffrey @comphead — a follow-up to my recently merged `hypot` PR, this adds a Spark-compatible `atan2` function to `datafusion-spark`. It follows the existing `math` conventions — `exact(Float64, Float64) -> Float64`, `invoke` via `make_scalar_function`, reimplemented self-contained (matching the 14/15 math functions that reimplement rather than delegate to core). Backed by Rust's `f64::atan2`. Covered by sqllogictest cases: all four quadrants, both axes, the negative x-axis (range to π), NULL propagation, NaN in every position (incl. `atan2(NaN, Infinity) = NaN` — note NaN propagates even over Infinity here, unlike `hypot`), all four infinity quadrants, signed zeros, and the array path. Closes #23961. Would appreciate a review when you have a moment. Thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
