kosiew commented on code in PR #23936: URL: https://github.com/apache/datafusion/pull/23936#discussion_r3672861490
########## datafusion/physical-plan/src/filter.rs: ########## Review Comment: Could we update this comment slightly? It currently says the filtered row count is always an estimate, but this PR now allows `filtered_num_rows` to be `Exact(0)`. Maybe clarify that counts are normally demoted because filter-derived row bounds are estimates, except when the row bound proves there are zero rows. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
