andygrove commented on code in PR #5079:
URL: https://github.com/apache/datafusion-comet/pull/5079#discussion_r3674183644
##########
spark/src/test/scala/org/apache/comet/CometCastSuite.scala:
##########
@@ -735,19 +735,6 @@ class CometCastSuite extends CometTestBase with
AdaptiveSparkPlanHelper {
}
test("cast DecimalType with negative scale to StringType") {
- // Negative-scale decimals are a legacy Spark feature gated on
- // spark.sql.legacy.allowNegativeScaleOfDecimal=true. Spark LEGACY cast
uses Java's
- // BigDecimal.toString() which produces scientific notation for
negative-scale values
- // (e.g. 12300 stored as Decimal(7,-2) with unscaled=123 → "1.23E+4").
- // CometCast.canCastToString checks the
- // config and returns Incompatible when it is false.
- //
- // Parquet does not support negative-scale decimals so we use
checkSparkAnswer directly
- // (no parquet round-trip) to avoid schema coercion.
-
- // With config enabled, enable localTableScan so Comet can take over the
full plan
- // and execute the cast natively. Parquet does not support negative-scale
decimals so
- // the data is kept in-memory; localTableScan.enabled bridges that gap.
Review Comment:
Why is the comment removed?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
