andygrove commented on code in PR #816:
URL: https://github.com/apache/datafusion-comet/pull/816#discussion_r1714434827
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -1205,15 +1210,15 @@ impl PhysicalPlanner {
// to copy the input batch to avoid the data corruption from reusing
the input
// batch.
let left = if can_reuse_input_batch(&left) {
- Arc::new(CopyExec::new(left))
+ Arc::new(CopyExec::new(left, CopyMode::UnpackOrDeepCopy))
Review Comment:
Note that `can_reuse_input_batch` returns `true` in fewer cases now, so we
are less likely to create the deep-copy version of CopyExec.
Previously we would create a `CopyExec` around any projection or filter, but
now we only do so if the projection or filter is wrapping a scan.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
