neilconway commented on PR #23977: URL: https://github.com/apache/datafusion/pull/23977#issuecomment-5119745346
FYI: I explored whether adding a null-free fast path to `VarianceAccumulator::update_batch` and `retract_batch` would be a win, following recent work on other accumulators (#23956, #23954, #23946). In this case, it didn't seem to be a significant win, probably because of the floating-point intensive work we do inside the accumulator itself, but the associated benchmarks and test improvements still seem useful. cc @viirya -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
