u70b3 commented on issue #23894: URL: https://github.com/apache/datafusion/issues/23894#issuecomment-5126190202
take — I'll fix `mod`'s zero-divisor handling in the shared `try_rem` helper, mirroring the shape #23898 established for `pmod`: - ANSI mode: raise for a zero divisor of any numeric type (including floating point, where Arrow's `rem` quietly returns `NaN`), with the check masked by the validity of the dividend to match Spark's null-intolerant semantics - Both modes: treat `-0.0` as a zero divisor (Arrow's total-order float comparisons don't match it against `0.0`) I'll replicate the `is_zero`/`negative_zero` helpers from #23898 so the two PRs stay consistent; whichever lands second can dedupe them in a rebase. Not touching #23897 here since that's a repo-wide error-text policy question. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
