hsiang-c commented on code in PR #4752:
URL: https://github.com/apache/datafusion-comet/pull/4752#discussion_r3680246969
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -130,7 +130,7 @@ case class CometScanRule(session: SparkSession)
case scan if !CometConf.COMET_NATIVE_SCAN_ENABLED.get(conf) =>
withFallbackReason(scan, "Comet Scan is not enabled")
- case scan if metadataCols(scan).nonEmpty =>
+ case scan: FileSourceScanExec if metadataCols(scan).nonEmpty =>
Review Comment:
(nit) Maybe we can move this check into L139 b/c this is V1 only check.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
