u70b3 commented on code in PR #23723:
URL: https://github.com/apache/datafusion/pull/23723#discussion_r3680863989
##########
datafusion/functions-table/src/generate_series.rs:
##########
@@ -417,7 +450,24 @@ impl<T: SeriesValue> LazyBatchGenerator for
GenericSeriesState<T> {
.should_stop(self.end.clone(), &self.step, self.include_end)
{
buf.push(self.current.to_value_type());
- self.current.advance(&self.step)?;
+ if self
Review Comment:
Thanks @kosiew — addressed in b4fcb2e03. `TimestampValue` now overrides
`advance_with_end`, treating an unrepresentable next timestamp as terminal
using the same end-clamping approach as `i64`; this also covers date series
because they use `TimestampValue`. I added SLT cases for a near-maximum
timestamp and date where the next step exceeds the nanosecond range.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
