kylebarron commented on code in PR #805:
URL: https://github.com/apache/datafusion-python/pull/805#discussion_r1714644524


##########
pyproject.toml:
##########
@@ -44,6 +44,7 @@ classifier = [
 ]
 dependencies = [
     "pyarrow>=11.0.0",
+    "typing-extensions",

Review Comment:
   It looks like you use typing.Self, which was [added in 
3.11](https://docs.python.org/3/library/typing.html#typing.Self). It looks like 
typing.deprecated was [added in 3.13](https://peps.python.org/pep-0702/), so 
you probably want
   ```suggestion
       "typing-extensions;python_version<'3.13'",
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to