github-actions[bot] commented on PR #24001: URL: https://github.com/apache/datafusion/pull/24001#issuecomment-5132192449
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion-physical-plan v54.1.0 (current) Built [ 45.203s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.143s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 39.260s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.144s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.625s] 223 checks: 221 pass, 2 fail, 0 warn, 30 skip --- failure trait_added_supertrait: non-sealed trait added new supertraits --- Description: A non-sealed trait added one or more supertraits, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#generic-bounds-tighten impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_added_supertrait.ron Failed in: trait datafusion_physical_plan::proto::ExecutionPlanDecode gained SealedPlanDispatch in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/proto.rs:125 trait datafusion_physical_plan::proto::ExecutionPlanEncode gained SealedPlanDispatch in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/proto.rs:97 --- failure trait_newly_sealed: pub trait became sealed --- Description: A publicly-visible trait became sealed, so downstream crates are no longer able to implement it ref: https://rust-lang.github.io/api-guidelines/future-proofing.html#sealed-traits-protect-against-downstream-implementations-c-sealed impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_newly_sealed.ron Failed in: trait datafusion_physical_plan::proto::ExecutionPlanEncode in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/proto.rs:97 trait datafusion_physical_plan::proto::ExecutionPlanDecode in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/proto.rs:125 Summary semver requires new major version: 2 major and 0 minor checks failed Finished [ 86.786s] datafusion-physical-plan Building datafusion-proto v54.1.0 (current) Built [ 62.387s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 62.378s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.019s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.244s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 126.303s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
