github-actions[bot] commented on PR #24018: URL: https://github.com/apache/datafusion/pull/24018#issuecomment-5135862782
<!-- semver-check-comment --> Thank you for opening this pull request! Reviewer note: [cargo-semver-checks](https://github.com/obi1kenobi/cargo-semver-checks) reported the current version number is not SemVer-compatible with the changes in this pull request (compared against the base branch). <details> <summary>Details</summary> ``` Cloning apache/main Building datafusion v54.1.0 (current) Built [ 124.970s] (current) Parsing datafusion v54.1.0 (current) Parsed [ 0.038s] (current) Building datafusion v54.1.0 (baseline) Built [ 118.362s] (baseline) Parsing datafusion v54.1.0 (baseline) Parsed [ 0.041s] (baseline) Checking datafusion v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.966s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 246.454s] datafusion Building datafusion-catalog v54.1.0 (current) Built [ 43.286s] (current) Parsing datafusion-catalog v54.1.0 (current) Parsed [ 0.027s] (current) Building datafusion-catalog v54.1.0 (baseline) Built [ 42.636s] (baseline) Parsing datafusion-catalog v54.1.0 (baseline) Parsed [ 0.028s] (baseline) Checking datafusion-catalog v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.158s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 87.199s] datafusion-catalog Building datafusion-datasource v54.1.0 (current) Built [ 43.625s] (current) Parsing datafusion-datasource v54.1.0 (current) Parsed [ 0.036s] (current) Building datafusion-datasource v54.1.0 (baseline) Built [ 43.476s] (baseline) Parsing datafusion-datasource v54.1.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion-datasource v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.365s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_datasource::source::DataSource::apply_expressions in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/source.rs:240 trait method datafusion_datasource::file::FileSource::apply_expressions in file /home/runner/work/datafusion/datafusion/datafusion/datasource/src/file.rs:372 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 88.717s] datafusion-datasource Building datafusion-datasource-arrow v54.1.0 (current) Built [ 42.337s] (current) Parsing datafusion-datasource-arrow v54.1.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-arrow v54.1.0 (baseline) Built [ 42.621s] (baseline) Parsing datafusion-datasource-arrow v54.1.0 (baseline) Parsed [ 0.013s] (baseline) Checking datafusion-datasource-arrow v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.098s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 86.120s] datafusion-datasource-arrow Building datafusion-datasource-avro v54.1.0 (current) Built [ 43.789s] (current) Parsing datafusion-datasource-avro v54.1.0 (current) Parsed [ 0.011s] (current) Building datafusion-datasource-avro v54.1.0 (baseline) Built [ 43.590s] (baseline) Parsing datafusion-datasource-avro v54.1.0 (baseline) Parsed [ 0.011s] (baseline) Checking datafusion-datasource-avro v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.102s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 88.718s] datafusion-datasource-avro Building datafusion-datasource-csv v54.1.0 (current) Built [ 42.638s] (current) Parsing datafusion-datasource-csv v54.1.0 (current) Parsed [ 0.012s] (current) Building datafusion-datasource-csv v54.1.0 (baseline) Built [ 42.766s] (baseline) Parsing datafusion-datasource-csv v54.1.0 (baseline) Parsed [ 0.012s] (baseline) Checking datafusion-datasource-csv v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.143s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 86.635s] datafusion-datasource-csv Building datafusion-datasource-json v54.1.0 (current) Built [ 43.173s] (current) Parsing datafusion-datasource-json v54.1.0 (current) Parsed [ 0.013s] (current) Building datafusion-datasource-json v54.1.0 (baseline) Built [ 42.984s] (baseline) Parsing datafusion-datasource-json v54.1.0 (baseline) Parsed [ 0.014s] (baseline) Checking datafusion-datasource-json v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.120s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 87.389s] datafusion-datasource-json Building datafusion-datasource-parquet v54.1.0 (current) Built [ 48.670s] (current) Parsing datafusion-datasource-parquet v54.1.0 (current) Parsed [ 0.034s] (current) Building datafusion-datasource-parquet v54.1.0 (baseline) Built [ 49.006s] (baseline) Parsing datafusion-datasource-parquet v54.1.0 (baseline) Parsed [ 0.037s] (baseline) Checking datafusion-datasource-parquet v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.218s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 99.225s] datafusion-datasource-parquet Building datafusion-ffi v54.1.0 (current) Built [ 65.514s] (current) Parsing datafusion-ffi v54.1.0 (current) Parsed [ 0.068s] (current) Building datafusion-ffi v54.1.0 (baseline) Built [ 65.066s] (baseline) Parsing datafusion-ffi v54.1.0 (baseline) Parsed [ 0.067s] (baseline) Checking datafusion-ffi v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.360s] 223 checks: 221 pass, 1 fail, 1 warn, 30 skip --- failure constructible_struct_adds_field: externally-constructible struct adds field --- Description: A pub struct constructible with a struct literal has a new pub field. Existing struct literals must be updated to include the new field. ref: https://doc.rust-lang.org/reference/expressions/struct-expr.html impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/constructible_struct_adds_field.ron Failed in: field FFI_PhysicalExpr.expression_id in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:123 field ForeignLibraryModule.create_exec_with_expressions in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:112 field FFI_ExecutionPlan.apply_expressions in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:56 field FFI_ExecutionPlan.version in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:101 --- warning repr_c_plain_struct_fields_reordered: struct fields reordered in repr(C) struct --- Description: A public repr(C) struct had its fields reordered. This can change the struct's memory layout, possibly breaking FFI use cases that depend on field position and order. ref: https://doc.rust-lang.org/reference/type-layout.html#reprc-structs impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/repr_c_plain_struct_fields_reordered.ron Failed in: FFI_ExecutionPlan.with_new_children moved from position 3 to 4, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:59 FFI_ExecutionPlan.name moved from position 4 to 5, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:63 FFI_ExecutionPlan.execute moved from position 5 to 6, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:67 FFI_ExecutionPlan.repartitioned moved from position 6 to 7, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:73 FFI_ExecutionPlan.metrics moved from position 7 to 8, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:82 FFI_ExecutionPlan.partition_statistics moved from position 8 to 9, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:88 FFI_ExecutionPlan.clone moved from position 9 to 10, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:95 FFI_ExecutionPlan.release moved from position 10 to 11, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:98 FFI_ExecutionPlan.private_data moved from position 11 to 13, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:105 FFI_ExecutionPlan.library_marker_id moved from position 12 to 14, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/execution_plan.rs:110 FFI_PhysicalExpr.display moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:126 FFI_PhysicalExpr.hash moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:129 FFI_PhysicalExpr.clone moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:133 FFI_PhysicalExpr.release moved from position 20 to 21, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:136 FFI_PhysicalExpr.version moved from position 21 to 22, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:139 FFI_PhysicalExpr.private_data moved from position 22 to 23, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:143 FFI_PhysicalExpr.library_marker_id moved from position 23 to 24, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/physical_expr/mod.rs:147 ForeignLibraryModule.create_exec_with_statistics moved from position 15 to 16, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:114 ForeignLibraryModule.create_table_with_statistics moved from position 16 to 17, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:116 ForeignLibraryModule.create_physical_optimizer_rule moved from position 17 to 18, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:119 ForeignLibraryModule.create_context_aware_optimizer_rule moved from position 18 to 19, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:121 ForeignLibraryModule.version moved from position 19 to 20, in /home/runner/work/datafusion/datafusion/datafusion/ffi/src/tests/mod.rs:123 Summary semver requires new major version: 1 major and 0 minor checks failed Warning produced 1 major and 0 minor level warnings Finished [ 132.502s] datafusion-ffi Building datafusion-physical-optimizer v54.1.0 (current) Built [ 43.389s] (current) Parsing datafusion-physical-optimizer v54.1.0 (current) Parsed [ 0.023s] (current) Building datafusion-physical-optimizer v54.1.0 (baseline) Built [ 43.782s] (baseline) Parsing datafusion-physical-optimizer v54.1.0 (baseline) Parsed [ 0.024s] (baseline) Checking datafusion-physical-optimizer v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.163s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 88.461s] datafusion-physical-optimizer Building datafusion-physical-plan v54.1.0 (current) Built [ 40.417s] (current) Parsing datafusion-physical-plan v54.1.0 (current) Parsed [ 0.156s] (current) Building datafusion-physical-plan v54.1.0 (baseline) Built [ 40.925s] (baseline) Parsing datafusion-physical-plan v54.1.0 (baseline) Parsed [ 0.155s] (baseline) Checking datafusion-physical-plan v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.963s] 223 checks: 222 pass, 1 fail, 0 warn, 30 skip --- failure trait_method_added: pub trait method added --- Description: A non-sealed public trait added a new method without a default implementation, which breaks downstream implementations of the trait ref: https://doc.rust-lang.org/cargo/reference/semver.html#trait-new-item-no-default impl: https://github.com/obi1kenobi/cargo-semver-checks/tree/v0.49.0/src/lints/trait_method_added.ron Failed in: trait method datafusion_physical_plan::execution_plan::ExecutionPlan::apply_expressions in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/execution_plan.rs:322 trait method datafusion_physical_plan::ExecutionPlan::apply_expressions in file /home/runner/work/datafusion/datafusion/datafusion/physical-plan/src/execution_plan.rs:322 Summary semver requires new major version: 1 major and 0 minor checks failed Finished [ 83.848s] datafusion-physical-plan Building datafusion-proto v54.1.0 (current) Built [ 65.460s] (current) Parsing datafusion-proto v54.1.0 (current) Parsed [ 0.019s] (current) Building datafusion-proto v54.1.0 (baseline) Built [ 66.541s] (baseline) Parsing datafusion-proto v54.1.0 (baseline) Parsed [ 0.021s] (baseline) Checking datafusion-proto v54.1.0 -> v54.1.0 (no change; assume patch) Checked [ 0.374s] 223 checks: 223 pass, 30 skip Summary no semver update required Finished [ 135.037s] datafusion-proto ``` </details> -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
