hsiang-c commented on code in PR #4752:
URL: https://github.com/apache/datafusion-comet/pull/4752#discussion_r3686185563
##########
spark/src/test/scala/org/apache/comet/CometIcebergNativeSuite.scala:
##########
@@ -4896,4 +5123,246 @@ class CometIcebergNativeSuite
}
}
}
+
+ test("partition evolution - _partition contains fields from all historical
specs") {
+ assume(icebergAvailable, "Iceberg not available in classpath")
+
+ withTempIcebergDir { warehouseDir =>
+ withSQLConf(
+ "spark.sql.catalog.test_cat" ->
"org.apache.iceberg.spark.SparkCatalog",
+ "spark.sql.catalog.test_cat.type" -> "hadoop",
+ "spark.sql.catalog.test_cat.warehouse" -> warehouseDir.getAbsolutePath,
+ CometConf.COMET_ENABLED.key -> "true",
+ CometConf.COMET_EXEC_ENABLED.key -> "true",
+ CometConf.COMET_ICEBERG_NATIVE_ENABLED.key -> "true") {
+
+ import org.apache.iceberg.catalog.TableIdentifier
+ import org.apache.iceberg.spark.SparkCatalog
+
+ spark.sql("""
+ CREATE TABLE test_cat.db.part_evolution (
+ id INT, region STRING, category STRING, value DOUBLE
+ ) USING iceberg PARTITIONED BY (region)
+ """)
+
+ spark.sql("""
+ INSERT INTO test_cat.db.part_evolution VALUES
+ (1, 'US', 'A', 10.0), (2, 'EU', 'B', 20.0)
+ """)
+
+ // Add a second partition field via Iceberg Java API (partition
evolution -> spec_id 1)
Review Comment:
(nit) Not a must, we can also use `ALTER TABLE` here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
