Smallfu666 opened a new pull request, #5160: URL: https://github.com/apache/datafusion-comet/pull/5160
Closes #5089 ## What changed * Removed Comet’s duplicated `is_valid_decimal_precision` helper. * Updated decimal SUM and AVG accumulators to use `Decimal128Type::is_valid_decimal_precision` from Arrow. * Removed imports that were only required by the duplicated implementation. ## Why Comet now depends on Arrow 58.4.0, which exposes the equivalent boolean precision-validation API. Keeping a local copy creates unnecessary duplication and risks the implementations diverging in the future. ## Validation * `cargo fmt --check` * `cargo clippy -p datafusion-comet-spark-expr --all-targets -- -D warnings` * `cargo test -p datafusion-comet-spark-expr` * `CometCastSuite` * `CometExecSuite` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
