tschwarzinger commented on code in PR #24000:
URL: https://github.com/apache/datafusion/pull/24000#discussion_r3689094310


##########
datafusion/physical-plan/src/filter.rs:
##########
@@ -2933,6 +2951,45 @@ mod tests {
             statistics.column_statistics[0].byte_size,
             Precision::Exact(0)
         );
+        assert_eq!(
+            statistics.column_statistics[1].null_count,
+            Precision::Exact(0)
+        );
+        assert_eq!(
+            statistics.column_statistics[1].distinct_count,
+            Precision::Exact(0)
+        );
+
+        // A contradictory predicate (`a = 1 AND a = 2`) proves the same for an

Review Comment:
   "proves the same" was a bit confusing for me. Maybe we can rephrase that. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to