kosiew commented on code in PR #1643:
URL:
https://github.com/apache/datafusion-python/pull/1643#discussion_r3689283778
##########
python/datafusion/functions/__init__.py:
##########
@@ -413,6 +414,11 @@ def isnan(expr: Expr) -> Expr:
return Expr(f.isnan(expr.expr))
+def is_nan(expr: Expr) -> Expr:
Review Comment:
Nice addition! Since `is_nan` is a direct alias of `isnan`, it might be
helpful to make that relationship a little more obvious in the docstring. A
short `See Also` reference to `isnan`, or reusing the existing `isnan` example,
would make the generated help a bit easier to navigate.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
