kosiew commented on code in PR #1642: URL: https://github.com/apache/datafusion-python/pull/1642#discussion_r3689320522
########## python/datafusion/user_defined.py: ########## Review Comment: Nice work separating the callable return type from the declared return field. Could we also update the public docstring from `return_field (_R)` to `return_field (pa.DataType | pa.Field)`? That would keep the generated docs from suggesting that the declared field is tied to the callable's Arrow array return type. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
