peterxcli commented on code in PR #5161:
URL: https://github.com/apache/datafusion-comet/pull/5161#discussion_r3694186712
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -855,6 +855,8 @@ case class CometScanTypeChecker() extends DataTypeSupport
with CometTypeShim {
name: String,
fallbackReasons: ListBuffer[String]): Boolean = {
dt match {
+ case _: YearMonthIntervalType | _: DayTimeIntervalType =>
Review Comment:
thanks for the review, filed
https://github.com/apache/datafusion-comet/issues/5189
##########
spark/src/test/scala/org/apache/comet/parquet/ParquetReadSuite.scala:
##########
@@ -125,6 +127,64 @@ abstract class ParquetReadSuite extends CometTestBase {
}
}
+ test("ANSI interval types") {
Review Comment:
addded:
```sql
"named_struct('ym', INTERVAL '1-2' YEAR TO MONTH, " +
"'dt', INTERVAL '1 02:03:04.5' DAY TO SECOND) AS interval_struct",
"array(INTERVAL '178956970-7' YEAR TO MONTH, " +
"INTERVAL '-178956970-8' YEAR TO MONTH) AS interval_array",
"map('max', INTERVAL '106751991 04:00:54.775807' DAY TO SECOND, " +
"'min', INTERVAL '-106751991 04:00:54.775808' DAY TO SECOND) AS
interval_map")
```
##########
spark/src/main/scala/org/apache/comet/rules/CometScanRule.scala:
##########
@@ -855,6 +855,8 @@ case class CometScanTypeChecker() extends DataTypeSupport
with CometTypeShim {
name: String,
fallbackReasons: ListBuffer[String]): Boolean = {
dt match {
+ case _: YearMonthIntervalType | _: DayTimeIntervalType =>
+ true
Review Comment:
filed: https://github.com/apache/datafusion-comet/issues/5188
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
