Braedon-Wooding-Displayr opened a new pull request, #24043:
URL: https://github.com/apache/datafusion/pull/24043
The SELECT list is planned by sql_to_expr, which infers placeholder types.
These four clauses are planned by sql_expr_to_logical_expr, which does not, so
the same expression written in both places does not compare equal.
The result is that a grouping key containing a placeholder is never matched
against the identical SELECT expression, and the columns inside it are reported
as ungrouped. The same query with literals in place of the placeholder plans
fine. QUALIFY fails differently, on a duplicate field name, because the typed
and untyped spellings print alike but are not equal.
Adds a planner test per clause.
## Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and
enhancements and this helps us generate change logs for our releases. You can
link an issue to this PR using the GitHub syntax. For example `Closes #123`
indicates that this PR will close issue #123.
-->
- Closes #24042.
## Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in
the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your
changes and offer better suggestions for fixes.
-->
I think it's clearly explained above / in issue.
## What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is
sometimes worth providing a summary of the individual changes in this PR.
-->
New tests for each clause case + inferring types in the clauses.
## Are these changes tested?
<!--
We typically require tests for all PRs in order to:
1. Prevent the code from being accidentally broken by subsequent changes
2. Serve as another way to document the expected behavior of the code
If tests are not included in your PR, please explain why (for example, are
they covered by existing tests)?
-->
Yes tests are there.
## Are there any user-facing changes?
No.
<!--
If there are user-facing changes then we may require documentation to be
updated before approving the PR.
-->
<!--
If there are any breaking changes to public APIs, please add the `api
change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
