berkaysynnada commented on PR #11966: URL: https://github.com/apache/datafusion/pull/11966#issuecomment-2286526287
> Thanks @ozankabak and @berkaysynnada -- I looked at the code logic and it looks good to me. > > I have several suggestions I think would make this PR better but they could also be done as a follow on PR (or never) Thanks for the quick review. I had initially removed the docs that didn't reflect the new version. I will restore them in this PR after making the updates. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org