neilconway commented on code in PR #24040:
URL: https://github.com/apache/datafusion/pull/24040#discussion_r3695757201
##########
datafusion/physical-plan/src/aggregates/group_values/multi_group_by/row_backed.rs:
##########
@@ -213,8 +213,13 @@ impl RowsGroupColumn {
.row_converter
.convert_rows(rows)
.expect("row conversion during emit");
- debug_assert_eq!(arrays.len(), 1, "single-field row converter");
- let array = arrays.swap_remove(0);
+ assert_eq!(
+ arrays.len(),
+ 1,
+ "Single field row converter must produce exactly one array, actual
length is {}",
Review Comment:
Nit: when the assert fails, it will already print the values, so "actual
length is ..." is redundant.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
