andygrove commented on issue #4311: URL: https://github.com/apache/datafusion-comet/issues/4311#issuecomment-5152189158
Closing this as superseded. We ended up taking the opposite default from what I proposed here — native-by-default where provably compatible, with JVM codegen dispatch as the in-pipeline fallback for divergent cases, which is closer to what @parthchandra argued for above. That turned out better than JVM-by-default: no JNI cost on the common path, and no Spark fallback on the divergent path. The concrete date/time work is done — 13 temporal expressions are pure `CometCodegenDispatch`, 7 more are native with `CodegenDispatchFallback`, and every date/time item in #4506's scope list has landed (`hour`/`minute`/`second` NTZ was fixed natively in #4753 rather than needing a JVM path). The #4310 config discussion this was blocked on is also closed. Remaining gaps are tracked elsewhere: collation-gated incompatibilities on `next_day` / `unix_timestamp` under #4646, and `Unsupported` input-type branches (`timestamp_seconds` with Decimal, `Hours`/`Days` with wrong types) which #4506 scopes out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
