fyrsta7 opened a new pull request, #24055: URL: https://github.com/apache/datafusion/pull/24055
## Which issue does this PR close? - Closes #19044. ## Rationale for this change HashJoinExec exposes several operator-specific metrics, but the metrics user guide did not document them yet. This PR follows the metrics documentation tracking issue by adding the HashJoinExec section. ## What changes are included in this PR? - Adds HashJoinExec operator-specific metrics to `docs/source/user-guide/metrics.md`. - Adds a note near `BuildProbeJoinMetrics` to keep metric descriptions in sync with the user guide. - Corrects the `probe_hit_rate` implementation comment to say "at least one match", matching the actual accounting. ## Are these changes tested? This is a documentation/comment-only change with no runtime behavior change. Checked locally: - `git diff --check` - `cargo fmt --check` - `./dev/rust_lint.sh` ## Are there any user-facing changes? Yes. The metrics user guide now documents the existing `HashJoinExec` metrics. There are no runtime behavior or public API changes. ## AI-assisted contribution note I reviewed the implementation and metric definitions end to end and do not have known unknowns or assumptions to call out. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
