andygrove commented on code in PR #5192: URL: https://github.com/apache/datafusion-comet/pull/5192#discussion_r3700024078
########## docs/source/contributor-guide/native_shuffle.md: ########## @@ -43,13 +43,12 @@ Comet Native (columnar) → ColumnarToRowExec → rows → JVM Shuffle → Arrow Native shuffle (`CometExchange`) is selected when all of the following conditions are met: -1. **Shuffle mode allows native**: `spark.comet.shuffle.mode` is `native` or `auto`. +1. **Shuffle mode allows native**: `spark.comet.exec.shuffle.mode` is `native` or `auto`. Review Comment: Actually, there probably shouldn't be updates the native shuffle documentation in the contributor guide as part of the `explode_outer` PR? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
