kosiew commented on code in PR #23908:
URL: https://github.com/apache/datafusion/pull/23908#discussion_r3702833848
##########
datafusion/ffi/tests/ffi_udaf.rs:
##########
@@ -66,6 +66,22 @@ mod tests {
Ok(())
}
+ #[test]
+ fn test_supports_null_handling_clause() -> Result<()> {
Review Comment:
Nice addition. Since this test already verifies the cross-library callback
and covers the FFI regression, it might also be worth registering the foreign
UDAFs in a `SessionContext` and checking the SQL planner behavior. For example,
you could assert that `first_value(...) IGNORE NULLS` plans successfully, while
`sum(...) IGNORE NULLS` is rejected. That would exercise the user-facing
planner boundary around `supports_null_handling_clause`, not just the direct
trait dispatch.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
