peterxcli opened a new pull request, #5228: URL: https://github.com/apache/datafusion-comet/pull/5228
## Which issue does this PR close? Closes #5209. Stacked on #4950 and should be merged after it. This also relies on the native `collect_set` normalization from #5166. ## Rationale for this change Spark 4.2 includes SPARK-57298 coverage for normalizing NaN and signed zero in `collect_set`. Comet previously ignored the scalar test because native `collect_set` did not implement those semantics. ## What changes are included in this PR? Regenerates `dev/diffs/4.2.0.diff` without the SPARK-57298 `IgnoreComet` marker. The nested complex-type test was already enabled, so both upstream tests now run without adding another diff file. ## How are these changes tested? - Applied the regenerated diff to a clean Spark v4.2.0 checkout. - Ran the two focused SPARK-57298 `DataFrameAggregateSuite` tests: 2 passed, 0 failed, 0 ignored. - Ran `CometSqlFileTestSuite collect_set_normalization` with Spark 4.2 against #5166: 2 passed for Parquet dictionary encoding on and off. - Ran `git diff --check`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
