mbutrovich opened a new pull request, #5232: URL: https://github.com/apache/datafusion-comet/pull/5232
## Which issue does this PR close? Closes #. ## Rationale for this change `SparkPhysicalExprAdapter::replace_with_spark_cast` (native, scan-time Parquet schema evolution) and `CometCast.isSupported` (Scala, Catalyst `Cast` expression legality) enforce two different Spark surfaces but feed the same native cast kernel, which made it easy to assume they should cross-check each other. Nothing is broken today, but neither function said which Spark reference it is supposed to track, inviting a future change to conflate the two. ## What changes are included in this PR? - Doc comment on `replace_with_spark_cast` noting it mirrors Spark's vectorized Parquet reader (`ParquetVectorUpdaterFactory.getUpdater`) for schema-evolution casts, not `CometCast.isSupported`. - Doc comment on the catch-all arm in `cast_array` naming both independent callers (`CometCast.isSupported` for the expression path, the schema adapter for the scan path) that are expected to have already gated the cast before it reaches the native kernel. ## How are these changes tested? Comment-only change, no behavior change. No new tests. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
