mbutrovich commented on PR #5201:
URL:
https://github.com/apache/datafusion-comet/pull/5201#issuecomment-5168106918
The diff fixes the tag-leak bug described in issue #5229:
`Literal.TrueLiteral` is a process-wide singleton, Catalyst's
`TreeNode.copyTagsFrom` welds a tag onto it the first time some expression that
gets rewritten into it carries one, and every later plan in the same JVM with
`dynamicpruningexpression(true)` then inherits that tag. The fix is in
`ExtendedExplainInfo.scala:277-294` (`collectExprTagValues` / `isNeverTagged`),
it is exercised by the dedicated regression test `CometCodegenSuite.scala:2516`
("tags copied onto the shared TrueLiteral do not leak into unrelated plans"),
and it benefits `EXTENSION_INFO` and `CODEGEN_DISPATCH_EXPRS`, not just the new
`NATIVE_EXPRS` tag. The description lists "Which issue does this PR close? N/A"
and #5229 is still open. Can you add `Closes #5229` (or `Fixes #5229`) so the
issue closes on merge and reviewers see this PR carries a bug fix, not only the
explain feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
