alamb commented on PR #11941: URL: https://github.com/apache/datafusion/pull/11941#issuecomment-2286864817
Thanks @Omega359 -- let's merge this to get the initial implementation and tests in and then we can work on improvements as a follow on PR. Let me know if you would like me to file a ticket for > I was looking at @Lordworms implementation in https://github.com/apache/datafusion/pull/11942 and I think it would make sense to align the two implementations. In some aspects I like his approach much more than the one I took in this PR. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: github-unsubscr...@datafusion.apache.org For additional commands, e-mail: github-h...@datafusion.apache.org
