u70b3 commented on PR #23987: URL: https://github.com/apache/datafusion/pull/23987#issuecomment-5168549802
Thanks for checking, @kumarUjjawal. There is some implementation overlap, but the two PRs fix different functions. #23898 is scoped to pmod: it rewrites spark_pmod so that it no longer uses try_rem, while leaving mod behavior unchanged. This PR fixes mod by correcting try_rem and adds coverage in mod.slt, closing #23894. The shared overlap is the negative_zero/is_zero helpers. I will rebase and deduplicate those helpers after whichever PR lands first. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
