emilk opened a new pull request, #24066: URL: https://github.com/apache/datafusion/pull/24066
## Which issue does this PR close? - Part of #18467. ## Rationale for this change The workspace already has a `[workspace.lints]` table, but it was missing from three crates and only enabled a handful of lints. This grows that set, using [egui's `Cargo.toml`](https://github.com/emilk/egui/blob/main/Cargo.toml) as a template, starting deliberately small: every lint added here is one that DataFusion violates **at most 10 times** today. Lints with more violations are left for follow-ups so this PR stays reviewable. ## What changes are included in this PR? One commit per step, each of which leaves `cargo clippy -D warnings` green: 1. Sort the existing `[workspace.lints.clippy]` list (no lint added/removed). 2. `datafusion-proto`, `-proto-common` and `-proto-models` were the only workspace members without `[lints] workspace = true` — enable it and fix the violations that surfaced. 3. Enable a batch of non-default clippy lints that are already violation-free. 4. One commit per lint that needed code fixes. CI already runs `cargo clippy ... -- -D warnings` via `ci/scripts/rust_clippy.sh`, so no CI change was needed. ## Are these changes tested? Covered by existing tests plus the clippy CI job. The code changes are mechanical (redundant paths, `unwrap_or_default`, `start.elapsed()`, …). ## Are there any user-facing changes? No. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
