andygrove commented on code in PR #791:
URL: https://github.com/apache/datafusion-comet/pull/791#discussion_r1715817136
##########
native/core/src/execution/datafusion/planner.rs:
##########
@@ -137,18 +138,6 @@ pub struct PhysicalPlanner {
session_ctx: Arc<SessionContext>,
}
-impl Default for PhysicalPlanner {
- fn default() -> Self {
- let session_ctx = Arc::new(SessionContext::new());
- let execution_props = ExecutionProps::new();
- Self {
- exec_context_id: TEST_EXEC_CONTEXT_ID,
- execution_props,
- session_ctx,
- }
- }
-}
Review Comment:
This `default` impl is only used in tests, so I moved it into the test module
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
